Re: [Qemu-devel] [PATCH v4 1/7] virtio-serial: add the virtio-serial device.

[Cornelia Huck]

On Fri, 29 Mar 2013 10:02:38 +0100
address@hidden wrote:

> From: KONRAD Frederic <address@hidden>
> 
> Create virtio-serial which extends virtio-device, so it can be connected
> on virtio-bus.
> 
> Signed-off-by: KONRAD Frederic <address@hidden>
> ---
>  hw/virtio-pci.c        |  2 +-
>  hw/virtio-serial-bus.c | 95 
> ++++++++++++++++++++++++++++++++++++++++++++++----
>  hw/virtio-serial.h     |  9 +++++
>  3 files changed, 98 insertions(+), 8 deletions(-)
> 
> diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
> index fb20722..6db67bf 100644
> --- a/hw/virtio-pci.c
> +++ b/hw/virtio-pci.c
> @@ -1075,7 +1075,7 @@ static Property virtio_serial_properties[] = {
>      DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2),
>      DEFINE_PROP_HEX32("class", VirtIOPCIProxy, class_code, 0),
>      DEFINE_VIRTIO_COMMON_FEATURES(VirtIOPCIProxy, host_features),
> -    DEFINE_PROP_UINT32("max_ports", VirtIOPCIProxy, 
> serial.max_virtserial_ports, 31),
> +    DEFINE_VIRTIO_SERIAL_PROPERTIES(VirtIOPCIProxy, serial),
>      DEFINE_PROP_END_OF_LIST(),
>  };
> 

Any reason why you convert only virtio-pci to the new define?
s390-virtio and virtio-ccw could use it as well.