qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 2/7] virtio-serial-pci: switch to the new API


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v4 2/7] virtio-serial-pci: switch to the new API.
Date: Wed, 3 Apr 2013 10:25:21 +0100

On 29 March 2013 09:02,  <address@hidden> wrote:
> -
> -    /* backwards-compatibility with machines that were created with
> -       DEV_NVECTORS_UNSPECIFIED */
> -    vdev->nvectors = proxy->nvectors == DEV_NVECTORS_UNSPECIFIED
> -                                        ? proxy->serial.max_virtserial_ports 
> + 1
> -                                        : proxy->nvectors;

> +
> +    if (vpci_dev->nvectors == DEV_NVECTORS_UNSPECIFIED) {
> +        vpci_dev->nvectors = dev->vdev.serial.max_virtserial_ports + 1;
> +    }
> +

You've lost the clarifying comment in moving this code;
could you add it back please?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]