|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH 20/35] hw: move ISA bridges and devices to hw/isa/, configure with default-configs/ |
| Date: | Wed, 03 Apr 2013 13:51:23 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 03/04/2013 12:51, Michael S. Tsirkin ha scritto:
>>> > > default-configs/i386-softmmu.mak | 4 ++++
>>> > > default-configs/x86_64-softmmu.mak | 4 ++++
>>> > > hw/i386/Makefile.objs | 7 ++-----
>>> > > hw/isa/Makefile.objs | 6 ++++++
>>> > > hw/{ => isa}/debugexit.c | 0
>>> > > hw/{ => isa}/lpc_ich9.c | 0
>>> > > hw/{ => isa}/pc-testdev.c | 0
>> >
>> > This at least seems wrong. debug devices should be in
>> > hw/debug or hw/test. And it does not matter that LPC
>> > uses some ISA ports. It's a chipset device.
>> > So hw/chipset or something ...
>> >
> Maybe hw/system/ or hw/bridge/
>
>
lpc_ich9.c is an ISA bridge, hence it is in hw/isa.
debugexit and pc-testdev are exceptions. I didn't really have a better
place.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |