[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V11 00/17] qmp/hmp interfaces for internal snaps
From: |
Wenchao Xia |
Subject: |
Re: [Qemu-devel] [PATCH V11 00/17] qmp/hmp interfaces for internal snapshot info |
Date: |
Sun, 07 Apr 2013 13:54:50 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 |
Hi, Kevin
Except the comments from Eric for better code comments, do you think
other things need improved? Modified patches is addressed as following,
I hope fix all in next version, to avoid using more time of reviewer.
>
> v11:
> General change:
> 5/17: check if snapshot > 0 on success in caller, add comments on the
> function says that caller need to check it on success.
> 7/17: check if snapshot > 0 on success before set info->has_snapshots.
>
> Address Eric's comments:
> 5/17: use error_setg_errno instead of strerror().
> 12/17: also move bdrv_snapshot_dump() since it need to be changed using
> GString later.
> 13/17: using GString as buffer.
> 14/17: using GString to dump snapshot info.
> 16/17: using GString to dump image info.
>
> Address Kevin's comments:
> 11/17: return void for bdrv_query_info().
> 17/17: spell fix in help message, using parameter "-v" to show
> verbose info.
>
--
Best Regards
Wenchao Xia
- [Qemu-devel] [PATCH V11 13/17] block: dump to buffer for bdrv_snapshot_dump() and bdrv_image_info_dump(), (continued)
- [Qemu-devel] [PATCH V11 16/17] hmp: show ImageInfo in 'info block', Wenchao Xia, 2013/04/02
- [Qemu-devel] [PATCH V11 15/17] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/04/02
- [Qemu-devel] [PATCH V11 17/17] hmp: add parameters device and -v for info block, Wenchao Xia, 2013/04/02
- [Qemu-devel] [PATCH V11 14/17] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/04/02
- Re: [Qemu-devel] [PATCH V11 00/17] qmp/hmp interfaces for internal snapshot info,
Wenchao Xia <=
- Re: [Qemu-devel] [PATCH V11 00/17] qmp/hmp interfaces for internal snapshot info, Kevin Wolf, 2013/04/08
- Re: [Qemu-devel] [PATCH V11 00/17] qmp/hmp interfaces for internal snapshot info, Stefan Hajnoczi, 2013/04/08
- Re: [Qemu-devel] [PATCH V11 00/17] qmp/hmp interfaces for internal snapshot info, Markus Armbruster, 2013/04/11