[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] New cpu-max field in query-machines QMP comm
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2] New cpu-max field in query-machines QMP command output |
Date: |
Mon, 08 Apr 2013 11:14:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/08/2013 10:41 AM, Michal Novotny wrote:
> Alter the query-machines QMP command to output information about
> maximum number of CPUs for each machine type with default value
> set to 1 in case the number of max_cpus is not set.
>
> Signed-off-by: Michal Novotny <address@hidden>
> ---
> qapi-schema.json | 4 +++-
> vl.c | 1 +
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index db542f6..689ca8d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -2861,11 +2861,13 @@
> #
> # @default: #optional whether the machine is default
> #
> +# @cpu-max: maximum number of CPUs supported by the machine type
Typically, when adding a field in a later version than the original
introduction of the datatype, we add '(since 1.5)' to make it obvious
when to expect the field. However, as nothing (currently) enforces this
rule, I think such an addition is minor enough that it wouldn't
invalidate the use of my:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2] New cpu-max field in query-machines QMP command output, Michal Novotny, 2013/04/08
- [Qemu-devel] Fwd: [PATCH v2] New cpu-max field in query-machines QMP command output, Michal Novotny, 2013/04/08
- Re: [Qemu-devel] [PATCH v2] New cpu-max field in query-machines QMP command output,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2] New cpu-max field in query-machines QMP command output, Luiz Capitulino, 2013/04/09
- Re: [Qemu-devel] [PATCH v2] New cpu-max field in query-machines QMP command output, Michal Novotny, 2013/04/09
- Re: [Qemu-devel] [PATCH v2] New cpu-max field in query-machines QMP command output, Luiz Capitulino, 2013/04/09
- Re: [Qemu-devel] [PATCH v2] New cpu-max field in query-machines QMP command output, Michal Novotny, 2013/04/09
- Re: [Qemu-devel] [PATCH v2] New cpu-max field in query-machines QMP command output, Luiz Capitulino, 2013/04/09
- Re: [Qemu-devel] [PATCH v2] New cpu-max field in query-machines QMP command output, Michal Novotny, 2013/04/09
- Re: [Qemu-devel] [PATCH v2] New cpu-max field in query-machines QMP command output, Peter Krempa, 2013/04/09