[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH-v2 1/2] virtio-scsi: create VirtIOSCSICommon
From: |
Nicholas A. Bellinger |
Subject: |
Re: [Qemu-devel] [PATCH-v2 1/2] virtio-scsi: create VirtIOSCSICommon |
Date: |
Mon, 08 Apr 2013 21:08:11 -0700 |
On Mon, 2013-04-08 at 16:59 -0500, Anthony Liguori wrote:
> "Nicholas A. Bellinger" <address@hidden> writes:
>
> > From: Paolo Bonzini <address@hidden>
> >
> > This patch refactors existing virtio-scsi code into VirtIOSCSICommon
> > in order to allow virtio_scsi_init_common() to be used by both internal
> > virtio_scsi_init() and external vhost-scsi-pci code.
> >
> > Changes in Patch-v2:
> > - Move ->get_features() assignment to virtio_scsi_init() instead of
> > virtio_scsi_init_common()
>
>
> Any reason we're not doing this as a QOM base class?
>
> Similiar to how the in-kernel PIT/PIC work using a common base class...
>
Mmm, not sure. Paolo, what do you prefer here..?
Also, has your qemu/scsi-next branch with this series been pushed to a
public tree yet..? ;)
--nab