Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

[Paolo Bonzini]

Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto:
> Hi liguang,
> 
>   Just to be curious, how much performance improvement this patch can get?

I think zero.  It is indeed making the code a tiny bit more readable in
the 2nd/3rd/5th/6th hunks.

But the 1st and 4th hunks, which do

-    num_insns = 0;

are wrong.  I'm surprised the compiler doesn't report usage of an
uninitialized variable.  liguang, how did you test them?

Paolo


> Regards,
> chenwj