[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU'
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU's reset method |
Date: |
Mon, 15 Apr 2013 14:20:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Am 15.04.2013 14:05, schrieb Paolo Bonzini:
> Now that we have a CPU object with a reset method, it is better to
> keep the KVM reset close to the CPU reset. Using qemu_register_reset
> as we do now keeps them far apart.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> v2->v3: add stub kvm_arch_reset_vcpu for s390
>
> include/sysemu/kvm.h | 2 --
> kvm-all.c | 11 -----------
> target-arm/kvm.c | 4 ----
> target-i386/cpu.c | 5 +++++
> target-i386/kvm_i386.h | 1 +
> target-ppc/kvm.c | 4 ----
> target-s390x/cpu.c | 4 ++++
> target-s390x/cpu.h | 5 +++++
> 8 files changed, 15 insertions(+), 21 deletions(-)
Fine with me.
Have you tested whether i386 needs a similar stub on non-x86? If so then
Reviewed-by: Andreas Färber <address@hidden>
For anyone else wondering, arm and ppc are no longer calling the
kvm_arch_ function, so it can get removed there, while i386 and s390x
call it from X86CPU/S390CPU reset handler now. Would be more clear if
the commit message was more verbose ;) and would be nice to clean this
up as follow-up by renaming to kvm_x86_... and kvm_s390_... or so
respectively.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg