[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-cpu-next 1/2] target-i386/cpu.c: Coding styl
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH qom-cpu-next 1/2] target-i386/cpu.c: Coding style fixes |
Date: |
Mon, 15 Apr 2013 15:18:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
Am 15.04.2013 10:27, schrieb Igor Mammedov:
> On Thu, 11 Apr 2013 17:07:23 -0300
> Eduardo Habkost <address@hidden> wrote:
>
>> * Add braces to 'if' statements;
>> * Remove last TAB character from the source.
>>
>> Signed-off-by: Eduardo Habkost <address@hidden>
>> ---
>> target-i386/cpu.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
>> index f1ccc72..c2e02fe 100644
>> --- a/target-i386/cpu.c
>> +++ b/target-i386/cpu.c
>> @@ -1870,12 +1870,13 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t
>> index, uint32_t count, if (env->cpuid_ext2_features & CPUID_EXT2_LM) {
>> /* 64 bit processor */
>> /* XXX: The physical address space is limited to 42 bits in exec.c. */
>> - *eax = 0x00003028; /* 48 bits virtual, 40 bits physical
>> */
>> + *eax = 0x00003028; /* 48 bits virtual, 40 bits physical */
> ^^ 2 spaces when in other places only one
>
>> } else {
>> - if (env->cpuid_features & CPUID_PSE36)
>> + if (env->cpuid_features & CPUID_PSE36) {
>> *eax = 0x00000024; /* 36 bits physical */
>> - else
>> + } else {
>> *eax = 0x00000020; /* 32 bits physical */
>> + }
>> }
>> *ebx = 0;
>> *ecx = 0;
>
> with fix above Reviewed-By: Igor Mammedov <address@hidden>
Thanks, applied to qom-cpu (with suggested change to spare resends):
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg