[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/15] blkverify: Use bdrv_open options instead
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 07/15] blkverify: Use bdrv_open options instead of filename |
Date: |
Mon, 15 Apr 2013 13:47:57 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/12/2013 02:48 PM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/blkverify.c | 94
> ++++++++++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 76 insertions(+), 18 deletions(-)
>
> /* Parse the blkverify: prefix */
> - if (strncmp(filename, "blkverify:", strlen("blkverify:"))) {
> - return -EINVAL;
> + if (!strstart(filename, "blkverify:", &filename)) {
> + error_setg(errp, "File name string must start with 'blkverify:'");
> + return;
> }
> - filename += strlen("blkverify:");
>
> /* Parse the raw image filename */
> c = strchr(filename, ':');
> if (c == NULL) {
> - return -EINVAL;
> + error_setg(errp, "blkdebug requires raw copy and original image
> path");
s/blkdebug/blkverify/
Simple enough fix that I'm still comfortable if you include:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 02/15] block: Add driver-specific options for backing files, (continued)
- [Qemu-devel] [PATCH 03/15] block: Enable filename option, Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 04/15] raw-posix: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 05/15] raw-win32: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 06/15] blkdebug: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 07/15] blkverify: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- Re: [Qemu-devel] [PATCH 07/15] blkverify: Use bdrv_open options instead of filename,
Eric Blake <=
- [Qemu-devel] [PATCH 08/15] curl: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 09/15] gluster: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 10/15] iscsi: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 11/15] rbd: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12
- [Qemu-devel] [PATCH 12/15] sheepdog: Use bdrv_open options instead of filename, Kevin Wolf, 2013/04/12