[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] hw/sm501: Use correct setter for sysbus-
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] hw/sm501: Use correct setter for sysbus-ohci dma-address property |
Date: |
Tue, 16 Apr 2013 17:10:58 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Tue, Apr 09, 2013 at 12:27:52PM +0100, Peter Maydell wrote:
> The sysbus-ohci dma-address property is declared as a HEX64
> property, not a TADDR, so use the correct setter for it.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/display/sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 6b660ac..3840bce 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -1430,7 +1430,7 @@ void sm501_init(MemoryRegion *address_space_mem,
> uint32_t base,
> /* bridge to usb host emulation module */
> dev = qdev_create(NULL, "sysbus-ohci");
> qdev_prop_set_uint32(dev, "num-ports", 2);
> - qdev_prop_set_taddr(dev, "dma-offset", base);
> + qdev_prop_set_uint64(dev, "dma-offset", base);
> qdev_init_nofail(dev);
> sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0,
> base + MMIO_BASE_OFFSET + SM501_USB_HOST);
Tested-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net