Re: [Qemu-devel] [PATCH 5/7] i440fx-test: add test to compare default register values

[Anthony Liguori]

Eric Blake <address@hidden> writes:

> On 04/16/2013 09:56 AM, Eric Blake wrote:
>> On 04/16/2013 08:45 AM, Anthony Liguori wrote:
>>> This test compares all of the default register values against the
>>> spec.  It turns out we deviate in quite a few places.  These
>>> places are really only visible to the BIOS though which is why
>>> this hasn't created any problems.
>>>
>>> The deviation actually happens in the core PCI layer so I suspect
>>> it's not a simple fix if we really care to fix it.  For now, just
>>>
>> 
>> Conclusion of sentence?
>
> Probably a case of your wording being similar to '#if 0 out the broken
> tests', and 'git commit' eating it because it looked like a comment.

Indeed :-/

Regards,

Anthony Liguori

>
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org