[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/17] aio: stop using .io_flush()
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/17] aio: stop using .io_flush() |
Date: |
Wed, 17 Apr 2013 15:20:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 17/04/2013 15:07, Stefan Hajnoczi ha scritto:
>
> Due to this change we need to update tests/test-aio.c which asserts
> aio_poll() return values. Note that QEMU doesn't actually rely on these
> return values so only tests/test-aio.c cares.
>
> Note that ctx->notifier, the EventNotifier fd used for aio_notify(), is
> now handled as a special case. This is a little ugly but maintains
> aio_poll() semantics, i.e. aio_notify() does not count as 'progress' and
> aio_poll() avoids blocking when the user has not set any fd handlers yet.
>
> Patches after this remove .io_flush() handler code until we can finally
> drop the io_flush arguments to aio_set_fd_handler() and friends.
Dropping aio_poll()'s return value is ok (as a follow up). The test
generally test for progress anyway with assertions on the results of the
notify callbacks.
Paolo
- [Qemu-devel] [PATCH v2 00/17] aio: drop io_flush(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 01/17] block: stop relying on io_flush() in bdrv_drain_all(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 06/17] block/curl: drop curl_aio_flush(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 09/17] block/linux-aio: drop qemu_laio_completion_cb(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 10/17] block/nbd: drop nbd_have_request(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 02/17] dataplane/virtio-blk: check exit conditions before aio_poll(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 05/17] aio: stop using .io_flush(), Stefan Hajnoczi, 2013/04/17
- Re: [Qemu-devel] [PATCH v2 05/17] aio: stop using .io_flush(),
Paolo Bonzini <=
- [Qemu-devel] [PATCH v2 04/17] tests: adjust test-thread-pool to new aio_poll() semantics, Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 13/17] block/ssh: drop return_true(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 03/17] tests: adjust test-aio to new aio_poll() semantics, Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 08/17] block/iscsi: drop iscsi_process_flush(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 12/17] block/sheepdog: drop have_co_req() and aio_flush_request(), Stefan Hajnoczi, 2013/04/17
- [Qemu-devel] [PATCH v2 16/17] tests: drop event_active_cb(), Stefan Hajnoczi, 2013/04/17