[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/8] ssh: Remove unnecessary use of strlen function.
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 7/8] ssh: Remove unnecessary use of strlen function. |
Date: |
Fri, 19 Apr 2013 13:34:00 +0200 |
From: "Richard W.M. Jones" <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block/ssh.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index b4e048c..93a8b53 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -387,15 +387,13 @@ static int check_host_key(BDRVSSHState *s, const char
*host, int port,
}
/* host_key_check=md5:xx:yy:zz:... */
- if (strlen(host_key_check) >= 4 &&
- strncmp(host_key_check, "md5:", 4) == 0) {
+ if (strncmp(host_key_check, "md5:", 4) == 0) {
return check_host_key_hash(s, &host_key_check[4],
LIBSSH2_HOSTKEY_HASH_MD5, 16);
}
/* host_key_check=sha1:xx:yy:zz:... */
- if (strlen(host_key_check) >= 5 &&
- strncmp(host_key_check, "sha1:", 5) == 0) {
+ if (strncmp(host_key_check, "sha1:", 5) == 0) {
return check_host_key_hash(s, &host_key_check[5],
LIBSSH2_HOSTKEY_HASH_SHA1, 20);
}
--
1.8.1.4
- [Qemu-devel] [PULL 0/8] Trivial patches for 13 to 19 April 2013, Stefan Hajnoczi, 2013/04/19
- [Qemu-devel] [PATCH 1/8] bswap: fix compiler warning, Stefan Hajnoczi, 2013/04/19
- [Qemu-devel] [PATCH 2/8] virtio.h: drop unused function prototypes, Stefan Hajnoczi, 2013/04/19
- [Qemu-devel] [PATCH 4/8] w64: Fix compiler warnings (wrong format specifier), Stefan Hajnoczi, 2013/04/19
- [Qemu-devel] [PATCH 3/8] Remove unneeded type casts, Stefan Hajnoczi, 2013/04/19
- [Qemu-devel] [PATCH 6/8] block/ssh: Add missing gcc format attributes, Stefan Hajnoczi, 2013/04/19
- [Qemu-devel] [PATCH 5/8] linux-user: change do_semop to return target errno when unsuccessful, Stefan Hajnoczi, 2013/04/19
- [Qemu-devel] [PATCH 8/8] m25p80: Remove bogus include of devices.h, Stefan Hajnoczi, 2013/04/19
- [Qemu-devel] [PATCH 7/8] ssh: Remove unnecessary use of strlen function.,
Stefan Hajnoczi <=