Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix recent compile breakage

[Peter Maydell]

On 22 April 2013 00:03, Andreas Färber <address@hidden> wrote:
> Even after this has been applied, things are still not building for me.
>
> I'm seeing CC trace/generated-events.o failing with "error: parameter
> name omitted" for trace_apic_local_deliver, trace_usb_xhci_queue_event,
> trace_megasas_msix_raise and trace_spapr_pci_msi_setup, plus a warning
> that trace_event_count is being declared twice.

I suspect that whatever compiler you're using here treats 'vector'
as a magic word, so when it sees a prototype like
  static inline void trace_megasas_msix_raise(int vector)

it's expecting that 'vector' is an attribute of the type and
it wants "int vector foo", hence the error message.

You could test this theory by changing all the 'vector's in
trace-events to 'vec' instead and rebuilding.

thanks
-- PMM