[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 23/28] dev-smartcard-reader: change default proto
From: |
Alon Levy |
Subject: |
[Qemu-devel] [PATCH v3 23/28] dev-smartcard-reader: change default protocol to T=0 |
Date: |
Mon, 22 Apr 2013 18:04:53 +0300 |
We don't support T=1 so we shouldn't advertise it by default.
Two independent changes:
* Default ATR
sets T=0. This gets overwritten by the client provided ATR later.
* Class descriptor
changes dwAdvertise dwProtocols.PPPP to 0x1 and dwProtocols.RRRR=0 per spec.
Signed-off-by: Alon Levy <address@hidden>
---
hw/usb/dev-smartcard-reader.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 0d482a9..8022f9f 100644
--- a/hw/usb/dev-smartcard-reader.c
+++ b/hw/usb/dev-smartcard-reader.c
@@ -335,8 +335,8 @@ static const uint8_t qemu_ccid_descriptor[] = {
*/
0x07, /* u8 bVoltageSupport; 01h - 5.0v, 02h - 3.0, 03 - 1.8 */
- 0x03, 0x00, /* u32 dwProtocols; RRRR PPPP. RRRR = 0000h.*/
- 0x00, 0x00, /* PPPP: 0001h = Protocol T=0, 0002h = Protocol T=1 */
+ 0x00, 0x00, /* u32 dwProtocols; RRRR PPPP. RRRR = 0000h.*/
+ 0x01, 0x00, /* PPPP: 0001h = Protocol T=0, 0002h = Protocol T=1 */
/* u32 dwDefaultClock; in kHZ (0x0fa0 is 4 MHz) */
0xa0, 0x0f, 0x00, 0x00,
/* u32 dwMaximumClock; */
@@ -875,7 +875,7 @@ static const CCID_ProtocolDataStructure
defaultProtocolDataStructure = {
static void ccid_reset_parameters(USBCCIDState *s)
{
- s->bProtocolNum = 1; /* T=1 */
+ s->bProtocolNum = 0; /* T=0 */
s->abProtocolDataStructure = defaultProtocolDataStructure;
}
--
1.8.2
- [Qemu-devel] [PATCH v3 14/28] dev-smartcard-reader: white space fixes, (continued)
- [Qemu-devel] [PATCH v3 14/28] dev-smartcard-reader: white space fixes, Alon Levy, 2013/04/22
- [Qemu-devel] [PATCH v3 18/28] dev-smartcard-reader: reuse usb.h definitions, Alon Levy, 2013/04/22
- [Qemu-devel] [PATCH v3 20/28] ccid-card-passthru: add atr check, Alon Levy, 2013/04/22
- [Qemu-devel] [PATCH v3 21/28] ccid-card-passthru, dev-smartcard-reader: add debug environment variables, Alon Levy, 2013/04/22
- [Qemu-devel] [PATCH v3 19/28] libcacard: change default ATR, Alon Levy, 2013/04/22
- [Qemu-devel] [PATCH v3 22/28] dev-smartcard-reader: define structs for CCID_Parameter internals, Alon Levy, 2013/04/22
- [Qemu-devel] [PATCH v3 25/28] libcacard/vreader: add debugging messages for apdu, Alon Levy, 2013/04/22
- [Qemu-devel] [PATCH v3 10/28] libcacard: vscclient to use QemuThread for portability, Alon Levy, 2013/04/22
- [Qemu-devel] [PATCH v3 26/28] libcacard: move atr setting from macro to function, Alon Levy, 2013/04/22
- [Qemu-devel] [PATCH v3 27/28] dev-smartcard-reader: empty implementation for Mechanical (fail correctly), Alon Levy, 2013/04/22
- [Qemu-devel] [PATCH v3 23/28] dev-smartcard-reader: change default protocol to T=0,
Alon Levy <=
- [Qemu-devel] [PATCH v3 28/28] libcacard/cac: change big switch functions to single return point, Alon Levy, 2013/04/22
- [Qemu-devel] [PATCH v3 24/28] dev-smartcard-reader: copy atr protocol to ccid parameters, Alon Levy, 2013/04/22
- Re: [Qemu-devel] [PATCH v3 00/28] ccid and libcacard fixes for windows/mingw, Marc-André Lureau, 2013/04/22