[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 11/12] rdma: core logic
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v5 11/12] rdma: core logic |
Date: |
Tue, 23 Apr 2013 22:59:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 23/04/2013 03:55, address@hidden ha scritto:
> +static size_t qemu_rdma_get_max_size(QEMUFile *f, void *opaque,
> + uint64_t transferred_bytes,
> + uint64_t time_spent,
> + uint64_t max_downtime)
> +{
> + static uint64_t largest = 1;
> + uint64_t max_size = ((double) (transferred_bytes / time_spent))
> + * max_downtime / 1000000;
> +
> + if (max_size > largest) {
> + largest = max_size;
> + }
> +
> + DPRINTF("MBPS: %f, max_size: %" PRIu64 " largest: %" PRIu64 "\n",
> + qemu_get_mbps(), max_size, largest);
> +
> + return largest;
> +}
Can you point me to the discussion of this algorithmic change and
qemu_get_max_size? It seems to me that it assumes that the IB link is
basically dedicated to migration.
I think it is a big assumption and it may be hiding a bug elsewhere. At
the very least, it should be moved to a separate commit and described in
the commit message, but actually I'd prefer to not include it in the
first submission.
Paolo
- [Qemu-devel] [PATCH v5 05/12] rdma: introduce qemu_file_mode_is_not_valid(), (continued)
- [Qemu-devel] [PATCH v5 05/12] rdma: introduce qemu_file_mode_is_not_valid(), mrhines, 2013/04/22
- [Qemu-devel] [PATCH v5 07/12] rdma: introduce ram_handle_compressed(), mrhines, 2013/04/22
- [Qemu-devel] [PATCH v5 01/12] rdma: add documentation, mrhines, 2013/04/22
- [Qemu-devel] [PATCH v5 06/12] rdma: export qemu_fflush(), mrhines, 2013/04/22
- [Qemu-devel] [PATCH v5 08/12] rdma: introduce qemu_ram_foreach_block(), mrhines, 2013/04/22
- [Qemu-devel] [PATCH v5 10/12] rdma: introduce capability x-rdma-pin-all, mrhines, 2013/04/22
- [Qemu-devel] [PATCH v5 09/12] rdma: new QEMUFileOps hooks, mrhines, 2013/04/22
- [Qemu-devel] [PATCH v5 12/12] rdma: send pc.ram, mrhines, 2013/04/22
- [Qemu-devel] [PATCH v5 02/12] rdma: export yield_until_fd_readable(), mrhines, 2013/04/22
- [Qemu-devel] [PATCH v5 11/12] rdma: core logic, mrhines, 2013/04/22
- Re: [Qemu-devel] [PATCH v5 11/12] rdma: core logic, Paolo Bonzini, 2013/04/23
- Re: [Qemu-devel] [PATCH v5 11/12] rdma: core logic, Michael R. Hines, 2013/04/23
Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support, Anthony Liguori, 2013/04/23