[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 20/20] tcg-arm: Remove long jump from tcg_out
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v6 20/20] tcg-arm: Remove long jump from tcg_out_goto_label |
Date: |
Wed, 24 Apr 2013 09:43:43 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Apr 23, 2013 at 01:46:52PM -0700, Richard Henderson wrote:
> Branches within a TB will always be within 16MB.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tcg/arm/tcg-target.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
> index d6afa2f..7216f7a 100644
> --- a/tcg/arm/tcg-target.c
> +++ b/tcg/arm/tcg-target.c
> @@ -1055,14 +1055,9 @@ static inline void tcg_out_goto_label(TCGContext *s,
> int cond, int label_index)
> {
> TCGLabel *l = &s->labels[label_index];
>
> - if (l->has_value)
> + if (l->has_value) {
> tcg_out_goto(s, cond, l->u.value);
> - else if (cond == COND_AL) {
> - tcg_out_ld32_12(s, COND_AL, TCG_REG_PC, TCG_REG_PC, -4);
> - tcg_out_reloc(s, s->code_ptr, R_ARM_ABS32, label_index, 31337);
> - s->code_ptr += 4;
> } else {
> - /* Probably this should be preferred even for COND_AL... */
> tcg_out_reloc(s, s->code_ptr, R_ARM_PC24, label_index, 31337);
> tcg_out_b_noaddr(s, cond);
> }
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v6 11/20] tcg-arm: Use TCG_REG_TMP name for the tcg temporary, (continued)
- [Qemu-devel] [PATCH v6 11/20] tcg-arm: Use TCG_REG_TMP name for the tcg temporary, Richard Henderson, 2013/04/23
- [Qemu-devel] [PATCH v6 13/20] tcg-arm: Cleanup multiply subroutines, Richard Henderson, 2013/04/23
- [Qemu-devel] [PATCH v6 14/20] tcg-arm: Cleanup most primitive load store subroutines, Richard Henderson, 2013/04/23
- [Qemu-devel] [PATCH v6 15/20] tcg-arm: Split out tcg_out_tlb_read, Richard Henderson, 2013/04/23
- [Qemu-devel] [PATCH v6 17/20] tcg-arm: Delete the 'S' constraint, Richard Henderson, 2013/04/23
- [Qemu-devel] [PATCH v6 16/20] tcg-arm: Improve scheduling of tcg_out_tlb_read, Richard Henderson, 2013/04/23
- [Qemu-devel] [PATCH v6 18/20] tcg-arm: Use movi32 + blx for calls on v7, Richard Henderson, 2013/04/23
- [Qemu-devel] [PATCH v6 20/20] tcg-arm: Remove long jump from tcg_out_goto_label, Richard Henderson, 2013/04/23
- Re: [Qemu-devel] [PATCH v6 20/20] tcg-arm: Remove long jump from tcg_out_goto_label,
Aurelien Jarno <=
- [Qemu-devel] [PATCH v6 19/20] tcg-arm: Convert to CONFIG_QEMU_LDST_OPTIMIZATION, Richard Henderson, 2013/04/23
- Re: [Qemu-devel] [PATCH v6 00/20] tcg-arm improvments, Peter Maydell, 2013/04/26
- Re: [Qemu-devel] [PATCH v6 00/20] tcg-arm improvments, Aurelien Jarno, 2013/04/26