Re: [Qemu-devel] [PATCH v2 2/5] block: vhdx header for the QEMU support of VHDX images

[Stefan Hajnoczi]

On Tue, Apr 23, 2013 at 10:24:21AM -0400, Jeff Cody wrote:
> +/* ---- HEADER SECTION STRUCTURES ---- */
> +
> +/* Important note: these structures are as defined in the VHDX specification,
> + * including byte order and size.  However, without being packed structures,
> + * they will not match 1:1 data read from disk.  Rather than use potentially
> + * non-portable packed structures, data is copied from read buffers into
> + * the structures below.  However, for reference, please refrain from
> + * modifying these structures to something that does not represent the spec 
> */

Outdated comment?  The patch uses QEMU_PACKED.

> +/* Header for the region table block */
> +#define VHDX_RT_MAGIC 0x69676572  /* 'regi ' */

Not worth respinnning, but should be 'regi' (4 bytes).