[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3 v3] Support for LED state extension to Qemu
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 0/3 v3] Support for LED state extension to Qemu VNC server |
|
Date: |
Wed, 24 Apr 2013 08:54:18 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 |
On 04/24/2013 04:12 AM, Lei Li wrote:
> Hi guys,
>
> This patch series tries to add support for LED state
> extension to Qemu VNC server. The proposal has been sent
> few days ago as link below:
>
> http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg01421.html
>
> The previous version as link:
>
> http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03988.html
>
> Pleae let me know if there is anything else need be improved.
Can you fix your setup to include a series diffstat in your cover
letter? I know that 'git send-email --cover-letter --annotate' does
this; but I also know that's not the workflow everyone uses. I just
updated http://wiki.qemu.org/Contribute/SubmitAPatch to mention that a
cover letter diffstat is a useful review aid (I'd much rather check a
0/n letter to see what files are touched in summary, rather than opening
n emails just to see if it touches any file I care about). I guess that
means I'm asking for a bit of help in further updating the wiki to
mention how to have git reliably include a cover letter diffstat, since
asking for something without giving a recipe of how to accomplish it
isn't very nice.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature