Re: [Qemu-devel] [PATCH 11/24] console: displaystate init revamp

[Markus Armbruster]

Gerd Hoffmann <address@hidden> writes:

> We have only one DisplayState, so there is no need for the "next"
> linking, rip it.  Also consolidate all displaystate initialization
> into init_displaystate().  This function is called by vl.c after
> creating the devices (and thus all QemuConsoles) and before
> initializing DisplayChangeListensers (aka gtk/sdl/vnc/spice ui).

Crashes for me on Fedora 17:

$ gdb --args qemu-system-x86_64 -nodefaults -S -vnc :0 -monitor stdio 
[...]
Program received signal SIGSEGV, Segmentation fault.
0x00000000006428b9 in surface_height (s=0x0)
    at /home/armbru/work/qemu/include/ui/console.h:253
253         return pixman_image_get_height(s->image);
[...]
(gdb) bt
#0  0x00000000006428b9 in surface_height (s=0x0)
    at /home/armbru/work/qemu/include/ui/console.h:253
#1  0x000000000064434a in vnc_dpy_switch (dcl=0x7fffebbd2050, surface=0x0)
    at /home/armbru/work/qemu/ui/vnc.c:587
#2  0x000000000061e97d in register_displaychangelistener (ds=0x14dbf30, dcl=
    0x7fffebbd2050) at /home/armbru/work/qemu/ui/console.c:1188
#3  0x000000000064a710 in vnc_display_init (ds=0x14dbf30)
    at /home/armbru/work/qemu/ui/vnc.c:2866
#4  0x000000000065627b in main (argc=8, argv=0x7fffffffe108, envp=
    0x7fffffffe150) at /home/armbru/work/qemu/vl.c:4370