[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_c
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients |
Date: |
Thu, 25 Apr 2013 15:45:04 -0500 |
User-agent: |
Notmuch/0.15.2+77~g661dcf8 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Eduardo Habkost <address@hidden> writes:
> On Thu, Apr 25, 2013 at 02:03:05PM -0500, Anthony Liguori wrote:
>> Laszlo Ersek <address@hidden> writes:
>> > --- /dev/null
>> > +++ b/hw/i386/acpi.h
>> > +
>> > +#include <stddef.h>
>>
>> QEMU style would normally be to use qemu-common.h here but honestly I
>> prefer using system headers when it's possible. Just FYI.
>
> I thought we were actively trying to stop including qemu-common.h from
> other header files, because it easily leads to unexpected (and hard to
> fix) circular header dependencies.
The problem is qemu-common including other headers, not other headers
including qemu-common...
But like I said in my original note, I don't like using qemu-common in
headers anyway.
Regards,
Anthony Liguori
>
> --
> Eduardo
- [Qemu-devel] [PATCH v4 5/7] hw/acpi: export acpi_checksum(), (continued)
- Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients, Laszlo Ersek, 2013/04/26
- Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients, Michael S. Tsirkin, 2013/04/29
- Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients, Kevin O'Connor, 2013/04/29
- Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients, Laszlo Ersek, 2013/04/29
- Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients, Michael S. Tsirkin, 2013/04/29
Re: [Qemu-devel] [PATCH v4 0/7] publish etc/acpi/APIC in fw_cfg, Laszlo Ersek, 2013/04/24