[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] add missing inclusions of config-host.h
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] add missing inclusions of config-host.h |
Date: |
Sat, 27 Apr 2013 23:08:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 27/04/2013 15:19, Peter Maydell ha scritto:
>>>> >> > The next patch will add a dependency of qemu/osdep.h on config-host.h.
>>>> >> > It could be nicer to use qemu-common.h, but I prefer to be safer this
>>>> >> > close to hard feature freeze.
>>> >> Can't we just include config-host.h from osdep.h ?
>> >
>> > Yes, but that is also a bit more risky than I think we can afford at
>> > this point.
> Not sure I understand where the risk is -- all it does is
> define a pile of CONFIG_* macros, right?
Yeah, I was unsure about triggering changes in all files that include
osdep.h, but there aren't that many actually. Most files get it via
qemu-common.h, and qemu-common.h includes config-host.h.
Paolo
[Qemu-devel] [PATCH 5/5] win32: add readv/writev emulation, Paolo Bonzini, 2013/04/27