[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_du
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump() |
Date: |
Thu, 2 May 2013 08:02:06 -0400 |
On Thu, 02 May 2013 10:05:08 +0800
Wenchao Xia <address@hidden> wrote:
> δΊ 2013-4-30 3:05, Luiz Capitulino ει:
> > On Fri, 26 Apr 2013 16:46:57 +0200
> > Stefan Hajnoczi <address@hidden> wrote:
> >
> >> On Fri, Apr 26, 2013 at 05:31:15PM +0800, Wenchao Xia wrote:
> >>> @@ -2586,10 +2585,12 @@ void do_info_snapshots(Monitor *mon, const QDict
> >>> *qdict)
> >>> }
> >>>
> >>> if (total > 0) {
> >>> - monitor_printf(mon, "%s\n", bdrv_snapshot_dump(buf, sizeof(buf),
> >>> NULL));
> >>> + bdrv_snapshot_dump(NULL);
> >>> + monitor_printf(mon, "\n");
> >>
> >> Luiz: any issue with mixing monitor_printf(mon) and
> >> monitor_vprintf(cur_mon) calls? I guess there was a reason for
> >> explicitly passing mon instead of relying on cur_mon.
> >
> > where are they being mixed?
> >
> bdrv_snapshot_dump() used a global variable "cur_mon" inside, instead
> of let caller pass in a explicit montior* "mon", I guess that is the
> question.
I'd have to see the code to tell, but yes, what Stefan described is the
best practice for the Monitor.
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Wenchao Xia, 2013/05/01
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(),
Luiz Capitulino <=
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Wenchao Xia, 2013/05/02
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Wenchao Xia, 2013/05/05
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Luiz Capitulino, 2013/05/06
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Wenchao Xia, 2013/05/14
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Luiz Capitulino, 2013/05/15
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Wenchao Xia, 2013/05/15
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Luiz Capitulino, 2013/05/16
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Wenchao Xia, 2013/05/16
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Luiz Capitulino, 2013/05/17
- Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for bdrv_snapshot_dump() and bdrv_image_info_dump(), Wenchao Xia, 2013/05/19