[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] blockdev: Replace "undefined error" in qmp_block_re

From: Kevin Wolf
Subject: [Qemu-devel] [PATCH] blockdev: Replace "undefined error" in qmp_block_resize
Date: Thu, 2 May 2013 15:32:55 +0200

We have an errno value that can be displayed, so we should just do that.
An easy way to reproduce this case is to resize a raw image to a size
that is too large for the host file system.

Signed-off-by: Kevin Wolf <address@hidden>
 blockdev.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/blockdev.c b/blockdev.c
index 6e293e9..7c9d8dd 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1118,6 +1118,7 @@ int do_drive_del(Monitor *mon, const QDict *qdict, 
QObject **ret_data)
 void qmp_block_resize(const char *device, int64_t size, Error **errp)
     BlockDriverState *bs;
+    int ret;
     bs = bdrv_find(device);
     if (!bs) {
@@ -1133,7 +1134,8 @@ void qmp_block_resize(const char *device, int64_t size, 
Error **errp)
     /* complete all in-flight operations before resizing the device */
-    switch (bdrv_truncate(bs, size)) {
+    ret = bdrv_truncate(bs, size);
+    switch (ret) {
     case 0:
     case -ENOMEDIUM:
@@ -1149,7 +1151,7 @@ void qmp_block_resize(const char *device, int64_t size, 
Error **errp)
         error_set(errp, QERR_DEVICE_IN_USE, device);
-        error_set(errp, QERR_UNDEFINED_ERROR);
+        error_setg_errno(errp, -ret, "Could not resize");

reply via email to

[Prev in Thread] Current Thread [Next in Thread]