[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29]

From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())
Date: Thu, 2 May 2013 17:17:04 +0300

On Thu, May 02, 2013 at 03:09:04PM +0100, Peter Maydell wrote:
> On 2 May 2013 14:51, Michael S. Tsirkin <address@hidden> wrote:
> > As it is, patchwork is full of patches that were already reviewed and
> > merged, all my scripts that were filtering and sorting patches are also
> > useless, and I get to wade through each patch for the second time.
> You need to fix patchwork to have some conception of a
> patch series. Then you can just select the whole series
> which is the pull request and say "ignore this" and you're
> done. Any patch-handling tool that doesn't let you operate
> at the level of a complete series is always going to mean
> you're doing huge amounts of busywork sometimes.

Sometimes I'm Cc'd on 1 patch out of series.
I might not want to go dig out the series only
to check if it actually needs review.

> I don't particularly object to suggesting that pullreq
> patches are all tagged 'PULL'; I don't think it's very
> likely that you'll get 100% consistency out of everybody
> though.
> -- PMM

As there's one person that does the merges, it's pretty
easy to get consistency. If you are not
sending a patch for review it's just wrong to say PATCH
in a subject. Or should I now ignore everything that
doesn't explicitly say [PATCH pleasereview] ?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]