[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29]

From: Anthony Liguori
Subject: Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())
Date: Thu, 02 May 2013 13:19:11 -0500
User-agent: Notmuch/0.15.2+77~g661dcf8 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu)

Paolo Bonzini <address@hidden> writes:

> Il 02/05/2013 18:06, Michael S. Tsirkin ha scritto:
>> On Thu, May 02, 2013 at 10:52:47AM -0500, Anthony Liguori wrote:
>>> Peter Maydell <address@hidden> writes:
>>>> On 2 May 2013 16:30, Paolo Bonzini <address@hidden> wrote:
>>>>> /me changes his scripts...
>>>>> -s/PATCH/PULL/ if (/PATCH 0+\\//);
>>>>> +s/PATCH/PULL/ if (/^Subject:/);
>>>>> Yes, Perl...
>>>> Heh, I use sed for this bit:
>>>> sed -i -e 's/^Subject: \[PULL\(.*\)].*/Subject: [PULL\1]
>>>> '"$BRANCHPFX"' queue/;/^$/q' "$COVERLETTER"
>>> You can also just do git format-patch --subject-prefix=PULL and avoid
>>> any fixups...
> I still want to avoid any mistakes in case I override the subject prefix
> (e.g. to include 1.5)... Keeping the substitution is cheap and a nice
> safety net.
>> Don't forget -M please, especially if you are Paolo :)
> Or
> [diff]
>         renames = true
>         renamelimit = 2000

BTW, this is all great stuff to put in a SubmitAPullRequest page on the
wiki.  I don't send pull requests so I don't have a script to do this,
but I'd encourage those that do to share their scripts on the wiki.


Anthony Liguori

> Paolo

reply via email to

[Prev in Thread] Current Thread [Next in Thread]