[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 0/7] push mmio dispatch out of big lock

From: liu ping fan
Subject: Re: [Qemu-devel] [PATCH v7 0/7] push mmio dispatch out of big lock
Date: Fri, 3 May 2013 15:37:22 +0800

On Fri, May 3, 2013 at 12:58 AM, Jan Kiszka <address@hidden> wrote:
> Hi Pingfan,
> On 2012-12-06 08:28, liu ping fan wrote:
>> Any suggestion? Or new design idea for this?
> Finally... I'm getting back to this. I'm currently trying to make use of
> this series, adapting it to my needs (selective BQL-free dispatching of
> PIO regions).
Glad that you are back :)

> Is there a newer version available on your side? This one obviously no

No, but I can see the code and rebase next week.

> longer applies due to all the code movements in QEMU. But it also seems
> to contain some bugs, at least in patch 5 (mixed up page number vs. page
> address around for address_space_section_lookup_ref).
Will pay some time to see it.

> Then we should get rid of the ref/unref callbacks. Making a memory
> region BQL-free must be as simple as setting a flag or (more likely)
> adding a reference to the owning QOM object in the region.
> Reimplementing ref/unref in device models over and over again is clearly
> a no-go. Maybe I'm currently forgetting a use case where overloading the

At the beginning, Avi suggest to enforce mr->opaque to be Device
object, but due to the nested embedded Object, we fail. And finally
Avi suggest ref/unref interface.
>From my point,  we can save lots of reimplementing ref/unref in device
models by telling whether mr->opauque is Object or not.  And leave not
object case to reimplement ref/unref.

> reference functions is needed, so please help my memory in that case.
> Jan
> --
> Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
> Corporate Competence Center Embedded Linux

reply via email to

[Prev in Thread] Current Thread [Next in Thread]