[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.

From: Jean-Christophe DUBOIS
Subject: Re: [Qemu-devel] [PATCH v2 2/4] Add i.MX I2C controller driver.
Date: Sun, 05 May 2013 14:34:34 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130404 Thunderbird/17.0.5

On 05/05/2013 01:34 PM, Andreas Färber wrote:
Am 05.05.2013 05:14, schrieb Peter Crosthwaite:
On Sun, May 5, 2013 at 12:09 AM, Jean-Christophe DUBOIS
<address@hidden> wrote:
diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c
new file mode 100644
index 0000000..5b0d046
--- /dev/null
+++ b/hw/i2c/imx_i2c.c
+typedef struct imx_i2c_state {
types should be in CamelCase IMXI2CState

+    SysBusDevice parent_obj;
While at it, please add a white line here. Background is that this
parent field will pretty likely go away once we switch to a better
object-orientation framework - if it were in a header we would annotate
it as private and thus hidden from documentation.

Will do.

+    MemoryRegion iomem;
+    i2c_bus *bus;
Please rather use i2c_bus bus; and qbus_create_inline() in instance_init.

I am using i2c_init_bus() which itself uses qbus_create().

Do you mean we should not use i2c_init_bus() but instead reimplement locally based on qbus_create_inline()?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]