[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/40] memory: allow memory_region_find() to run
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 02/40] memory: allow memory_region_find() to run on non-root memory regions |
Date: |
Tue, 7 May 2013 16:35:30 +0100 |
On 7 May 2013 15:16, Paolo Bonzini <address@hidden> wrote:
> memory_region_find() is similar to registering a MemoryListener and
> checking for the MemoryRegionSections that come from a particular
> region. There is no reason for this to be limited to a root memory
> region.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> include/exec/memory.h | 13 +++++++------
> memory.c | 20 +++++++++++++++-----
> 2 files changed, 22 insertions(+), 11 deletions(-)
>
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index 9e88320..efe210b 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -725,17 +725,18 @@ void memory_region_set_alias_offset(MemoryRegion *mr,
> *
> * Returns a #MemoryRegionSection that describes a contiguous overlap.
> * It will have the following characteristics:
> - * address@hidden >= @addr
> - * address@hidden + address@hidden <= @addr + @size
> * address@hidden = 0 iff no overlap was found
> * address@hidden is non-%NULL iff an overlap was found
> *
> - * @address_space: a top-level (i.e. parentless) region that contains
> - * the region to be found
> - * @addr: start of the area within @address_space to be searched
> + * If @mr is parent-less,
> + * address@hidden >= @addr
> + * address@hidden + address@hidden <= @addr + @size
Shouldn't we also say something about what you get back
in the "@mr is not parentless" case?
> + *
> + * @mr: a (possibly indirect) parent that contains the region to be found
> + * @addr: start of the area within @as to be searched
There's no @as parameter...
> * @size: size of the area to be searched
> */
> -MemoryRegionSection memory_region_find(MemoryRegion *address_space,
> +MemoryRegionSection memory_region_find(MemoryRegion *mr,
> hwaddr addr, uint64_t size);
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 08/40] memory: limit sections in the radix tree to the actual address space size, (continued)
[Qemu-devel] [PATCH 15/40] vfio: abort if an emulated iommu is used, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 05/40] memory: do not duplicate memory_region_destructor_none, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 30/40] misc: add memory_region_set_owner calls, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 22/40] dma: eliminate DMAContext, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 32/40] vga: add memory_region_set_owner calls, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 02/40] memory: allow memory_region_find() to run on non-root memory regions, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 18/40] spapr: use memory core for iommu support, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 24/40] memory: add getter/setter for owner, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 07/40] memory: fix address space initialization/destruction, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 17/40] spapr: make IOMMU translation go through IOMMUTLBEntry, Paolo Bonzini, 2013/05/07
[Qemu-devel] [PATCH 40/40] memory: add reference counting to FlatView, Paolo Bonzini, 2013/05/07