Re: [Qemu-devel] [PATCH 01/40] memory: assert that PhysPageEntry's ptr does not overflow

[Peter Maydell]

On 7 May 2013 17:08, Paolo Bonzini <address@hidden> wrote:
>> Da: "Peter Maydell" <address@hidden>
>> Why is the limit we're asserting not the same as the maximum
>> size that we pass to g_renew() below?
>
> That's a minimum size, isn't it?

Doh, so it is.

> I'm asserting that the physical section number doesn't overflow into
> the page, since the TLB entries are stored as a combination of the two.

Maybe this could use a comment about where (in what data
structure) the section number lives, because it's not
entirely obvious (well, to me anyway).

-- PMM