[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/6] pflash_cfi01: memory region should be se
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/6] pflash_cfi01: memory region should be set to enable readonly mode |
Date: |
Tue, 07 May 2013 22:35:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 07/05/2013 19:15, Jordan Justen ha scritto:
> This causes any writes to the memory region to trap to the
> device handler.
>
> This is also important for KVM, because this allows the memory
> region to be set using KVM_MEM_READONLY, which allows the memory
> region to be read & executed. (Without this, KVM will not support
> executing from the memory region.)
>
> Signed-off-by: Jordan Justen <address@hidden>
> ---
> hw/block/pflash_cfi01.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
> index 3ff20e0..b65225e 100644
> --- a/hw/block/pflash_cfi01.c
> +++ b/hw/block/pflash_cfi01.c
> @@ -596,6 +596,8 @@ static int pflash_cfi01_init(SysBusDevice *dev)
> }
> }
>
> + memory_region_set_readonly(&pfl->mem, true);
> +
> if (pfl->bs) {
> pfl->ro = bdrv_is_read_only(pfl->bs);
> } else {
>
NACK, romd mode already implies this. See my review of patch 3.
Paolo
- [Qemu-devel] [PATCH v4 0/6] KVM flash memory support, Jordan Justen, 2013/05/07
- [Qemu-devel] [PATCH v4 2/6] kvm: add kvm_readonly_mem_enabled, Jordan Justen, 2013/05/07
- [Qemu-devel] [PATCH v4 4/6] pflash_cfi01: memory region should be set to enable readonly mode, Jordan Justen, 2013/05/07
- Re: [Qemu-devel] [PATCH v4 4/6] pflash_cfi01: memory region should be set to enable readonly mode,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v4 5/6] pc_sysfw: allow flash (-pflash) memory to be used with KVM, Jordan Justen, 2013/05/07
- [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions, Jordan Justen, 2013/05/07
- Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions, Paolo Bonzini, 2013/05/07
- Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions, Jordan Justen, 2013/05/07
- Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions, Peter Maydell, 2013/05/07
- Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions, Paolo Bonzini, 2013/05/07
- Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions, Jordan Justen, 2013/05/07
- Re: [Qemu-devel] [PATCH v4 3/6] kvm: support using KVM_MEM_READONLY flag for readonly regions, Jan Kiszka, 2013/05/07
[Qemu-devel] [PATCH v4 1/6] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS), Jordan Justen, 2013/05/07
[Qemu-devel] [PATCH v4 6/6] pc_sysfw: change rom_only default to 0, Jordan Justen, 2013/05/07