[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/10] qapi: add support for lists of native
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/10] qapi: add support for lists of native types |
Date: |
Fri, 10 May 2013 11:43:55 -0400 |
On Fri, 10 May 2013 17:40:20 +0200
Laszlo Ersek <address@hidden> wrote:
> On 05/10/13 17:30, Luiz Capitulino wrote:
> > On Thu, 9 May 2013 21:20:52 -0500
> > Michael Roth <address@hidden> wrote:
> >
> >> These patches apply on top of qemu.git master, and can also be obtained
> >> from:
> >> git://github.com/mdroth/qemu.git qapi-native-lists
> >>
> >> Sending this now since a number of series have popped up in the past that
> >> wanted this, and Amos has some pending patches (query-mac-tables) that rely
> >> on this as well.
> >>
> >> These patches add support for specifying lists of native qapi types
> >> (int/bool/str/number) like so:
> >>
> >> { 'type': 'foo',
> >> 'data': { 'bar': ['int'] }}
> >>
> >> for a 'bar' field that is a list of type 'int',
> >>
> >> { 'type': 'foo2',
> >> 'data': { 'bar2': ['str'] }}
> >>
> >> for a 'bar2' field that is a list of type 'str', and so on.
> >>
> >> This uses linked list types for the native C representations, just as we do
> >> for complex schema-defined types. In the future we may add schema
> >> annotations
> >> of some sort to specify a more natural/efficient array type for the C
> >> representations, but this should serve the majority of uses-cases for now.
> >
> > Series looks good to me. I'd drop patch 06/10 if it's not required
> > for this series though.
>
> I guess:
I see, although it's still a separate issue (which I'd personally fix
in a different series).
>
> On 05/10/13 04:20, Michael Roth wrote:
> > v1->v2:
> > * fixed do-nothing float tests in pre-existing code and updated new
> > unit tests accordingly (Laszlo)
> > * added a fix for a bug in json parser that was exposed by above change
>
> Laszlo
>
- Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values, (continued)
Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values, Luiz Capitulino, 2013/05/10
[Qemu-devel] [PATCH 07/10] qapi: fix visitor serialization tests for numbers/doubles, Michael Roth, 2013/05/09
[Qemu-devel] [PATCH 08/10] qapi: add native list coverage for visitor serialization tests, Michael Roth, 2013/05/09
[Qemu-devel] [PATCH 09/10] qapi: add native list coverage for QMP output visitor tests, Michael Roth, 2013/05/09
[Qemu-devel] [PATCH 10/10] qapi: add native list coverage for QMP input visitor tests, Michael Roth, 2013/05/09
Re: [Qemu-devel] [PATCH v2 00/10] qapi: add support for lists of native types, Luiz Capitulino, 2013/05/10