[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 5/7] sd.c: introduce async read operation
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC 5/7] sd.c: introduce async read operation |
Date: |
Mon, 13 May 2013 14:10:09 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, May 10, 2013 at 08:10:23PM +0400, Igor Mitsyanko wrote:
> + if (sd->state != sd_sendingdata_state) {
> + DPRINTF("Transfer was aborted\n");
> + return;
> + }
> +
> + io_len = (sd->ocr & (1 << 30)) ? 512 : sd->blk_len;
If you respin, a constant would be nice instead of the 1 << 30 magic
number.
- [Qemu-devel] [RFC 0/7] Convert SD card model to AIO, Igor Mitsyanko, 2013/05/10
- [Qemu-devel] [RFC 1/7] sd.c: introduce AIO related members in SD state, Igor Mitsyanko, 2013/05/10
- [Qemu-devel] [RFC 2/7] sd.c: introduce variable for trekking valid data, Igor Mitsyanko, 2013/05/10
- [Qemu-devel] [RFC 3/7] sd.c: introduce "start bit" and "busy deasserted" callbacks, Igor Mitsyanko, 2013/05/10
- [Qemu-devel] [RFC 4/7] sd.c: use callbacks as a flag to use async IO, Igor Mitsyanko, 2013/05/10
- [Qemu-devel] [RFC 5/7] sd.c: introduce async read operation, Igor Mitsyanko, 2013/05/10
- Re: [Qemu-devel] [RFC 5/7] sd.c: introduce async read operation,
Stefan Hajnoczi <=
- [Qemu-devel] [RFC 6/7] sd.c: introduce async write interface, Igor Mitsyanko, 2013/05/10
- [Qemu-devel] [RFC 7/7] pl181.c: convert to async IO SD card interface, Igor Mitsyanko, 2013/05/10
- Re: [Qemu-devel] [RFC 0/7] Convert SD card model to AIO, Stefan Hajnoczi, 2013/05/13