[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts

From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts
Date: Mon, 13 May 2013 23:29:41 +0300

On Mon, May 13, 2013 at 09:22:20PM +0100, Peter Maydell wrote:
> On 13 May 2013 21:00, Michael S. Tsirkin <address@hidden> wrote:
> > apic has its own version of bitops, with the
> > difference that it works on u32 and not long.
> > Add apic_ prefix to avoid namespace clashes.
> Wouldn't it be better to consolidate so we only have
> one set of bitops rather than a local set in this file?
> thanks
> -- PMM

Yes but I'd like this patchset to focus on acpi.
ATM including bitops in pc.h gives build errors.

Thus this trivial patch, can be tested by comparing binary.
Consolidation is better done in a separate patchset,
and would need more testing.

Any chance you can do this on top of this?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]