[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RESEND PATCH for-1.5] acpi: add dummy write function f
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [RESEND PATCH for-1.5] acpi: add dummy write function for acpi timer |
Date: |
Tue, 14 May 2013 14:45:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
On 05/14/13 14:29, Gerd Hoffmann wrote:
> Otherwise the guest can crash qemu (NULL pointer dereference).
>
> https://bugzilla.redhat.com/show_bug.cgi?id=947691
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/acpi/core.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/hw/acpi/core.c b/hw/acpi/core.c
> index 64b8718..42eeace 100644
> --- a/hw/acpi/core.c
> +++ b/hw/acpi/core.c
> @@ -462,8 +462,15 @@ static uint64_t acpi_pm_tmr_read(void *opaque, hwaddr
> addr, unsigned width)
> return acpi_pm_tmr_get(opaque);
> }
>
> +static void acpi_pm_tmr_write(void *opaque, hwaddr addr, uint64_t val,
> + unsigned width)
> +{
> + /* nothing */
> +}
> +
> static const MemoryRegionOps acpi_pm_tmr_ops = {
> .read = acpi_pm_tmr_read,
> + .write = acpi_pm_tmr_write,
> .valid.min_access_size = 4,
> .valid.max_access_size = 4,
> .endianness = DEVICE_LITTLE_ENDIAN,
>
(Hopefully the low-hanging fruit impression it makes is not a trap!)
Reviewed-by: Laszlo Ersek <address@hidden>