Re: [Qemu-devel] [PATCH 2/2] pc: reject do pc_acpi_init if acpi_enabled is false

[li guang]

在 2013-05-15三的 10:38 +0200，Paolo Bonzini写道：
> Il 15/05/2013 06:01, liguang ha scritto:
> > Signed-off-by: liguang <address@hidden>
> 
> --verbose, please.
> 
> What problem does this patch fix?

Oh, sorry to be lazy ...
QEMU's option '-no-acpi' seems does not play
a correct role, even started with this, 
ACPI tables will also be embedded into BIOS, 
and there's no different between with or without it
for q35, as i can see.

here, I'm assuming '-no-acpi' is to disable ACPI.

> 
> > ---
> >  hw/i386/pc.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> > index 197d218..77025a8 100644
> > --- a/hw/i386/pc.c
> > +++ b/hw/i386/pc.c
> > @@ -982,7 +982,7 @@ void pc_acpi_init(const char *default_dsdt)
> >  {
> >      char *filename;
> >  
> > -    if (acpi_tables != NULL) {
> > +    if (acpi_tables != NULL || !acpi_enabled) {
> >          /* manually set via -acpitable, leave it alone */
> >          return;
> >      }
> > 
>