[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 7/8] blockdev: add Abort transaction

From: Wenchao Xia
Subject: Re: [Qemu-devel] [PATCH v3 7/8] blockdev: add Abort transaction
Date: Thu, 16 May 2013 10:26:38 +0800
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5

于 2013-5-16 3:01, Eric Blake 写道:
On 05/15/2013 08:34 AM, Stefan Hajnoczi wrote:
The Abort action can be used to test QMP 'transaction' failure.  Add it
as the last action to exercise the .abort() and .cleanup() code paths
for all previous actions.

Signed-off-by: Stefan Hajnoczi <address@hidden>
  blockdev.c       | 15 +++++++++++++++
  qapi-schema.json | 11 ++++++++++-
  2 files changed, 25 insertions(+), 1 deletion(-)

I like it!  Even though libvirt will never use it, I can see how having
it definitely helps development of other transaction actions.

+++ b/qapi-schema.json
@@ -1630,6 +1630,14 @@
              '*mode': 'NewImageMode', '*speed': 'int' } }

+# @Abort
+# This action can be used to test transaction failure.
+{ 'type': 'Abort',
+  'data': { } }

Probably should add a Since: 1.6 notation.  With that,

Reviewed-by: Eric Blake <address@hidden>

  Nice to have it for injecting error.

Reviewed-by: Wenchao Xia <address@hidden>

Best Regards

Wenchao Xia

reply via email to

[Prev in Thread] Current Thread [Next in Thread]