[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb()

From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v3 1/8] block: add bdrv_add_before_write_cb()
Date: Thu, 16 May 2013 10:11:33 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, May 15, 2013 at 04:42:57PM +0200, Paolo Bonzini wrote:
> Il 15/05/2013 16:34, Stefan Hajnoczi ha scritto:
> > The bdrv_add_before_write_cb() function installs a callback that is
> > invoked before a write request is processed.  This will be used to
> > implement copy-on-write point-in-time snapshots where we need to copy
> > out old data before overwriting it.
> Perhaps a notifier list that receives the BdrvTrackedRequest?  (BTW we
> should probably remove all the notifier_remove wrappers, they're useless).

Nice idea, done in v4.  I originally rejected NotifierList because it
only has a void * argument, but BdrvRequest has the information we need.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]