[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_re

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] scsi: reset cdrom tray statuses on scsi_disk_reset
Date: Thu, 16 May 2013 09:42:53 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5

On 05/16/2013 09:34 AM, Pavel Hrdina wrote:
> Tray statuses should be also reseted. Some guests may lock the tray


> and after reset before any kernel is loaded the tray should be unlocked.
> Also if you reset the real computer the tray is closed. We should
> do the same in qemu.

Is that OS-independent hardware behavior, or is tray closing on boot
merely a side effect observed on bare metal but caused by installed
software (BIOS or OS code)?  At any rate, being consistent with IDE
doesn't hurt.

> This fix is already commited for IDE CD.


> Check the commit a7f3d65b65b8c86a5ff0c0abcfefb45e2ec6fe4c.
> Signed-off-by: Pavel Hrdina <address@hidden>
> ---
>  hw/scsi/scsi-disk.c | 3 +++
>  1 file changed, 3 insertions(+)

assuming the maintainer can touch up the commit message, feel free to add:

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]