[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with h

From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH] target-moxie: replace target_phys_addr_t with hwaddr
Date: Fri, 17 May 2013 10:26:21 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5

Anthony G.,

Am 15.05.2013 10:23, schrieb Peter Maydell:
> On 15 May 2013 07:04, Hu Tao <address@hidden> wrote:
>> target_phys_addr_t has been already replaced by hwaddr, but this
>> one is introduced after.
>> Signed-off-by: Hu Tao <address@hidden>
> Reviewed-by: Peter Maydell <address@hidden>
> This doesn't cause compile errors because it's in a bit
> of code that can never get compiled (it's inside a
> CONFIG_USER_ONLY block but there is no moxie-linux-user
> target in configure).

A similar issue had come up before and I don't remember seeing a clear

Are you planning to actually implement moxie-linux-user and enable it by
default, so that we can catch any errors? Or should we rather drop any
such unused CONFIG_USER_ONLY code from target-moxie?


SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]