[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] scsi: reset cdrom tray statuses on scsi_disk
Re: [Qemu-devel] [PATCH v2] scsi: reset cdrom tray statuses on scsi_disk_reset
Mon, 20 May 2013 13:21:23 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
Il 20/05/2013 13:06, Pavel Hrdina ha scritto:
> Tray statuses should be also reset. Some guests may lock the tray and
> right after resetting the guest it should be unlocked and closed. This
> is done on power-on, reset and resume from suspend/hibernate on bare-metal.
> This fix is already committed for IDE CD.
> Check the commit a7f3d65b65b8c86a5ff0c0abcfefb45e2ec6fe4c.
> Test results on bare-metal:
> - on reset/power-on the CD-ROM tray is closed even before the monitor
> is turned on
> - on resume from suspend/hibernate the tray is also closed before
> the monitor is turned on
> From test results it seems that this behavior is OS and probably BIOS
> Signed-off-by: Pavel Hrdina <address@hidden>
Applied to scsi-next branch, thanks.
> hw/scsi/scsi-disk.c | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index c8d2a99..02733dc 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -1984,6 +1984,9 @@ static void scsi_disk_reset(DeviceState *dev)
> s->qdev.max_lba = nb_sectors;
> + /* reset tray statuses */
> + s->tray_locked = 0;
> + s->tray_open = 0;
> static void scsi_destroy(SCSIDevice *dev)