Re: [Qemu-devel] [PATCH 0/6] local state directory fixes for win32 qga

[mdroth]

On Sat, May 18, 2013 at 06:31:47AM +0200, Laszlo Ersek wrote:
> Qouting patch 2/6:
> 
> > Since commit 39097daf ("qemu-ga: use key-value store to avoid
> > recycling fd handles after restart") we've relied on the state
> > directory for the fd handles' key-value store. Even though we don't
> > support the guest-file-* commands on win32 yet, the key-value store is
> > written, and it's the first use of the state directory on win32. We
> > should have a sensible default for its location.
> 
> Motivated by RHBZ#962669.
> 
> I've perpetrated this in the second half of a Friday->Sunday
> all-nighter, so be gentle. Thanks.

:)

I still need to do some testing to make sure our w32 incantations are
doing what we expect, but I reviewed your series and it looks good to
me. Also, thanks to 4/7 and the fact that the keystore isn't currently
used on w32, we should be able to switch existing users to the new
default state directory without any problems.

Series:

Reviewed-by: Michael Roth <address@hidden>

> 
> Laszlo Ersek (6):
>   osdep: add qemu_get_local_state_pathname()
>   qga: determine default state dir and pidfile dynamically
>   configure: don't save any fixed local_statedir for win32
>   qga: create state directory on win32
>   qga: remove undefined behavior in ga_install_service()
>   qga: save state directory in ga_install_service()
> 
>  configure            |   12 +++++++---
>  include/qemu/osdep.h |   11 +++++++++
>  qga/service-win32.h  |    3 +-
>  qga/main.c           |   57 +++++++++++++++++++++++++++++++++++++++++++------
>  qga/service-win32.c  |   25 ++++++++++++++--------
>  util/oslib-posix.c   |    9 ++++++++
>  util/oslib-win32.c   |   22 +++++++++++++++++++
>  7 files changed, 118 insertions(+), 21 deletions(-)
>