[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to o

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line
Date: Mon, 20 May 2013 10:41:19 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6

On 05/20/2013 10:21 AM, Peter Maydell wrote:
> Reformat the qapi-schema TargetType enumeration so that it has just
> one target architecture name per line. This allows patches for
> adding new targets to just add a single line, rather than having
> to reformat most of the list (resulting in a hard-to-check diff).
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> d15a9c23 is an example of what you get otherwise.
> I would much prefer it if we autogenerated this list so you didn't
> need to change this file at all to add a new target, but Anthony
> is against that; so this is at least an improvement.

Yep, that raises (once again) the question of dynamic introspection -
there's a difference between the maximum amount of information known at
compile time, and the subset of enum values that are actually usable at
runtime.  This list is static (all known architectures), depending on
what solutions we come up with for dynamic introspection, maybe that
solution will also have a way for generating enum types.

>  qapi-schema.json |   30 ++++++++++++++++++++++++++----
>  1 file changed, 26 insertions(+), 4 deletions(-)

At any rate, I see no harm in taking this patch as-is now, while we
still spend time thinking about introspection.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]