[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/4] build: TARGET_ARCH/ARCH2/TYPE simplific
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC PATCH 0/4] build: TARGET_ARCH/ARCH2/TYPE simplification |
Date: |
Mon, 20 May 2013 22:33:09 +0100 |
On 20 May 2013 21:57, Andreas Färber <address@hidden> wrote:
> Am 20.05.2013 19:23, schrieb Paolo Bonzini:
> Add to that
>
> - TARGET_BASE_ARCH in Makefile.target is assumed to be the name of the
> target-* subdirectory, but this will not always be desirable.
Isn't it the name of the target-* subdirectory by definition?
(ie we need to be able to set that somehow if you have a subarch
that's piggybacking on another subarch, and this is how we set it).
> For a long time already I have been carrying the following patch
> introducing TARGET_ARCH_DIR:
> https://github.com/afaerber/qemu-rl78/commit/9eddd60dae6603235fddf9070c73e5bf65edf292
>
> Still need to rebase that, but it looks as if there are no conflicts
> with your series.
It seems to me that if you're going to put the source code in
the target-rl78 directory you should make rl78 the
TARGET_BASE_ARCH. Alternatively call the directory target-78k0
if you want the TARGET_BASE_ARCH to be 78k0.
thanks
-- PMM