[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] configure: Autogenerate default target list

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 1/2] configure: Autogenerate default target list
Date: Tue, 21 May 2013 00:09:57 +0100

On 20 May 2013 22:11, Andreas Färber <address@hidden> wrote:
> Am 20.05.2013 17:16, schrieb Peter Maydell:
>> Autogenerate the default target list based on what files exist
>> in default-configs; this allows us to remove one of the places
>> that has to be kept up to date with a complete list of every
>> target we support.
>> Signed-off-by: Peter Maydell <address@hidden>
> In the past we have had differences between targets compilable and
> targets fully implemented and thus not in the default list (mipsn32 and
> mips64 linux-user). They could then be tested by the brave using
> --target-list and --disable-werror.

I suspect that any target we have in tree but not in the default
list is liable to bitrot because nobody will compile test it
(and indeed nobody knows about it since it's undocumented).

That said, we could have an experimental-configs/ to go with
default-configs/, such that we allow --target-list=foo if
there's an experimental-configs/ file but don't default to
it (and we could even print a "warning, this is an experimental
target!" message if we were feeling friendly, and have an
--enable-experimental-targets options so buildbots could at
least compiletest them).

I'm not sure that's worth the effort at this point when we don't
actually have any targets in tree which aren't enabled by default,
though. (I did cross-check the old and new lists so this patch
isn't accidentally enabling a previously disabled config.)

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]