[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 14/30] memory: create FlatView for new address s

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 14/30] memory: create FlatView for new address spaces
Date: Tue, 21 May 2013 13:03:40 +0100

On 21 May 2013 11:57, Paolo Bonzini <address@hidden> wrote:
> Even a new address space might have a non-empty FlatView.  In order
> to initialize it properly, address_space_init should (a) call
> memory_region_transaction_commit after the address space is inserted
> into the list; (b) force memory_region_transaction_commit to do something.
> This bug was latent so far because all address spaces started empty, including
> the PCI address space where the bus master region is initially disabled.
> However, the target address space of an IOMMU is usually rooted at
> get_system_memory(), which might not be empty at the time the IOMMU is 
> created.
> Signed-off-by: Paolo Bonzini <address@hidden>

The patch title should probably be "populate FlatView for new address
spaces", not "create". Given that,

Reviewed-by: Peter Maydell <address@hidden>

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]