[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] tests: set MALLOC_PERTURB_ to expose memory
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] tests: set MALLOC_PERTURB_ to expose memory bugs |
|
Date: |
Tue, 21 May 2013 09:58:45 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
On 05/21/2013 09:17 AM, Stefan Hajnoczi wrote:
>>> + MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(($RANDOM % 255 + 1))} \
>>
>> This is a Makefile; don't you need to use $$ instead of $ (three instances)?
>>
>
> Silly me. I did test it but it silently "worked".
Yep, quite a fluke. GNU Make expands it to:
MALLOC_PERTURB_=
which meant you were setting it to the empty variable; and thus had no
randomness but no syntax error to tell you your mistake.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature