qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 1/1] configure: Probe for libfdt_env.h


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v1 1/1] configure: Probe for libfdt_env.h
Date: Wed, 22 May 2013 09:26:49 +0100

On 22 May 2013 08:47, Edgar E. Iglesias <address@hidden> wrote:
> On Wed, May 22, 2013 at 11:50:22AM +1000, address@hidden wrote:
>> From: Peter Crosthwaite <address@hidden>
>> Currently QEMU provides a local clone of the file libfdt_env.h in
>> /include. This file is supposed to come with the libfdt package and is
>> only needed for broken installs of libfdt. Unfortunately, libfdt 1.3
>> stable is tagged with this bug so we cant realistically remove the
>> clone. So instead, use a configure time probe - check to see if the
>> host is already providing this file, and if so, don't use QEMUs
>> local clone of libfdt.h.
>>
>> Moved include/libfdt_env.h to include/libfdt/libfdt_env.h so it can be
>> treated as a special case.
>>
>> For newer (development) versions of libfdt this probe will succeed and
>> include/libfdt/libfdt_env.h will simply be ignored.

> Should we consider removing our builtin version and stick to either
> using the hosts or when that fails suggest the submoduled dtc pkg?

I agree that that sounds like a better idea: just add the #include
to our existing fdt probe, and then we'll simply ignore system libfdt
if it's not new enough. The relevant changes got committed to libfdt
git in 2008, after all....

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]