[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] wdt_i6300esb: fix vmstate versioning

From: Richard W.M. Jones
Subject: Re: [Qemu-devel] [PATCH v2] wdt_i6300esb: fix vmstate versioning
Date: Wed, 22 May 2013 17:46:38 +0100
User-agent: Mutt/1.5.20 (2009-12-10)

On Wed, May 22, 2013 at 11:32:51AM -0500, Michael Roth wrote:
> When this VMSD was introduced it's version fields were set to
> sizeof(I6300State), making them essentially random from build to build,
> version to version.
> To fix this, we lock in a high version id and low minimum version id to
> support old->new migration from all prior versions of this device's
> state. This should work since the device state has not changed since
> its introduction.
> The potentially breaks migration from 1.5+ to 1.5, but since the
> versioning was essentially random prior to this patch, new->old
> migration was not consistently functional to begin with.
> Reported-by: Nicholas Thomas <address@hidden>
> Suggested-by: Peter Maydell <address@hidden>
> Cc: address@hidden
> Signed-off-by: Michael Roth <address@hidden>

ACK.  I guess no one uses watchdog much, or they don't try to
migrate those guests :-(


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]